linux-kernel - Re: [PATCH v1] perf kvm powerpc: Fix build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cjD4KQaC2LyDhRMfPP8ccbxba_pRHEmVn90S6Nok+U3ug@mail.gmail.com>
Date: Tue, 6 Feb 2024 16:01:26 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>, 
	Leo Yan <leo.yan@...aro.org>, James Clark <james.clark@....com>, 
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
	sfr@...b.auug.org.au
Subject: Re: [PATCH v1] perf kvm powerpc: Fix build

On Tue, Feb 6, 2024 at 3:59 PM Ian Rogers <irogers@...gle.com> wrote:
>
> Updates to struct parse_events_error needed to be carried through to
> PowerPC specific event parsing.
>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Fixes: fd7b8e8fb20f ("perf parse-events: Print all errors")
> Signed-off-by: Ian Rogers <irogers@...gle.com>

Acked-by: Namhyung <namhyung@...nel.org>

Thanks for the quick fix!
Namhyung


> ---
>  tools/perf/arch/powerpc/util/kvm-stat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/powerpc/util/kvm-stat.c b/tools/perf/arch/powerpc/util/kvm-stat.c
> index d9a0ac1cdf30..c8357b571ccf 100644
> --- a/tools/perf/arch/powerpc/util/kvm-stat.c
> +++ b/tools/perf/arch/powerpc/util/kvm-stat.c
> @@ -114,7 +114,7 @@ static int is_tracepoint_available(const char *str, struct evlist *evlist)
>
>         parse_events_error__init(&err);
>         ret = parse_events(evlist, str, &err);
> -       if (err.str)
> +       if (ret)
>                 parse_events_error__print(&err, "tracepoint");
>         parse_events_error__exit(&err);
>         return ret;
> --
> 2.43.0.594.gd9cf4e227d-goog
>