[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <35eca42a-5bb0-4d24-972b-6fe2fb4d87ab@tuxon.dev>
Date: Tue, 6 Feb 2024 07:54:48 +0200
From: claudiu beznea <claudiu.beznea@...on.dev>
To: Mihai Sain <mihai.sain@...rochip.com>, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/8] ARM: dts: microchip: sam9x60ek: Add power-supply
properties for sdmmc nodes
Hi, Mihai,
On 05.02.2024 10:00, Mihai Sain wrote:
> The sdmmc0 and sdmmc1 controllers are powered from 3.3V regulator.
> Add vmmc-supply and vqmmc-supply properties to sdmmc nodes.
> The sdmmc controller from SAM9X60 MPU doesn't support the IO voltage signaling/switching required by the UHS sd-card.
Please wrap the line at 75 chars (see [1]).
Thank you,
Claudiu Beznea
[1]
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#the-canonical-patch-format.
> In order to use the sd high-speed mode, keep vqmmc at 3V3.
>
> Signed-off-by: Mihai Sain <mihai.sain@...rochip.com>
> ---
> arch/arm/boot/dts/microchip/at91-sam9x60ek.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> index f3cbb675cea4..b19a0956dc97 100644
> --- a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> @@ -560,6 +560,8 @@ &sdmmc0 {
> status = "okay";
> cd-gpios = <&pioA 23 GPIO_ACTIVE_LOW>;
> disable-wp;
> + vmmc-supply = <&vdd1_3v3>;
> + vqmmc-supply = <&vdd1_3v3>;
> };
>
> &sdmmc1 {
> @@ -568,6 +570,8 @@ &sdmmc1 {
> pinctrl-0 = <&pinctrl_sdmmc1_default>;
> no-1-8-v;
> non-removable;
> + vmmc-supply = <&vdd1_3v3>;
> + vqmmc-supply = <&vdd1_3v3>;
> status = "disabled"; /* Conflict with flx4. */
> };
>
Powered by blists - more mailing lists