linux-kernel - Re: [PATCH 2/2] dt-bindings: trivial-devices: Add qca,spidev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 6 Feb 2024 08:44:36 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Paweł Owoc <frut3k7@...il.com>,
 Rob Herring <robh+dt@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Guenter Roeck <linux@...ck-us.net>,
 Naresh Solanki <Naresh.Solanki@...ements.com>,
 Patrick Rudolph <patrick.rudolph@...ements.com>,
 Peter Yin <peteryin.openbmc@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Michal Simek <michal.simek@....com>, Lakshmi Yadlapati
 <lakshmiy@...ibm.com>, Lukas Wunner <lukas@...ner.de>,
 Alexander Stein <alexander.stein@...tq-group.com>,
 Fabio Estevam <festevam@...x.de>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: Add qca,spidev

On 05/02/2024 20:18, Paweł Owoc wrote:
> Add Qualcomm QCA4024 to trivial devices.
> 
> Signed-off-by: Paweł Owoc <frut3k7@...il.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 79dcd92c4a43..50efbdf2a735 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -309,6 +309,8 @@ properties:
>            - plx,pex8648
>              # Pulsedlight LIDAR range-finding sensor
>            - pulsedlight,lidar-lite-v2
> +            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
> +          - qca,spidev

There is no such hardware as spidev and you even mentioned it is called
QCA4024, not spidev. Please don't use that name but a real name.

Also, I have doubts that Bluetooth is a trivial device. Such devices
need supplies, have reset/powerdown GPIOs.

Best regards,
Krzysztof