[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAM9d7cgeEmoKmk3qCUdxsCRRx1mUERf6Mz6PgRtsaY+7+F9FhQ@mail.gmail.com>
Date: Mon, 5 Feb 2024 17:13:50 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>, Nick Terrell <terrelln@...com>,
Kan Liang <kan.liang@...ux.intel.com>, Andi Kleen <ak@...ux.intel.com>,
Kajol Jain <kjain@...ux.ibm.com>, Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
Huacai Chen <chenhuacai@...nel.org>, Masami Hiramatsu <mhiramat@...nel.org>,
"Steinar H. Gunderson" <sesse@...gle.com>, Liam Howlett <liam.howlett@...cle.com>,
Miguel Ojeda <ojeda@...nel.org>, Colin Ian King <colin.i.king@...il.com>,
Dmitrii Dolgov <9erthalion6@...il.com>, Yang Jihong <yangjihong1@...wei.com>,
Ming Wang <wangming01@...ngson.cn>, James Clark <james.clark@....com>,
K Prateek Nayak <kprateek.nayak@....com>, Sean Christopherson <seanjc@...gle.com>, Leo Yan <leo.yan@...aro.org>,
Ravi Bangoria <ravi.bangoria@....com>, German Gomez <german.gomez@....com>,
Changbin Du <changbin.du@...wei.com>, Paolo Bonzini <pbonzini@...hat.com>, Li Dong <lidong@...o.com>,
Sandipan Das <sandipan.das@....com>, linux-kernel@...r.kernel.org,
linux-perf-users@...r.kernel.org, Guilherme Amadio <amadio@...too.org>
Subject: Re: [PATCH v8 00/25] maps/threads/dsos memory improvements and fixes
On Thu, Feb 1, 2024 at 10:15 PM Ian Rogers <irogers@...gle.com> wrote:
>
> Modify the implementation of maps to not use an rbtree as the
> container for maps, instead use a sorted array. Improve locking and
> reference counting issues.
>
> Similar to maps separate out and reimplement threads to use a hashmap
> for lower memory consumption and faster look up. The fixes a
> regression in memory usage where reference count checking switched to
> using non-invasive tree nodes. Reduce its default size by 32 times
> and improve locking discipline. Also, fix regressions where tids had
> become unordered to make `perf report --tasks` and
> `perf trace --summary` output easier to read.
>
> Better encapsulate the dsos abstraction. Remove the linked list and
> rbtree used for faster iteration and log(n) lookup to a sorted array
> for similar performance but half the memory usage per dso. Improve
> reference counting and locking discipline, adding reference count
> checking to dso.
>
> v8:
> - in "perf maps: Switch from rbtree to lazily sorted array for
> addresses" use accessors and remove some duplicative invariant checks as
> requested by Namhyung.
>
> v7:
> - rebase to latest perf-tools-next where 22 patches were applied by Arnaldo.
> - resolve merge conflicts, in particular with fc044c53b99f ("perf
> annotate-data: Add dso->data_types tree") that required more dso
> accessor functions.
>
> v6 series is here:
> https://lore.kernel.org/lkml/20231207011722.1220634-1-irogers@google.com/
>
> Ian Rogers (25):
> perf maps: Switch from rbtree to lazily sorted array for addresses
> perf maps: Get map before returning in maps__find
> perf maps: Get map before returning in maps__find_by_name
> perf maps: Get map before returning in maps__find_next_entry
> perf maps: Hide maps internals
> perf maps: Locking tidy up of nr_maps
Can you please send patch 1-6 separately with my Ack? - provided
you fixed the issue in the patch 1.
For patch 1-6:
Acked-by: Namhyung Kim <namhyung@...nel.org>
I'll review others later.
Thanks,
Namhyung
> perf dso: Reorder variables to save space in struct dso
> perf report: Sort child tasks by tid
> perf trace: Ignore thread hashing in summary
> perf machine: Move fprintf to for_each loop and a callback
> perf threads: Move threads to its own files
> perf threads: Switch from rbtree to hashmap
> perf threads: Reduce table size from 256 to 8
> perf dsos: Attempt to better abstract dsos internals
> perf dsos: Tidy reference counting and locking
> perf dsos: Add dsos__for_each_dso
> perf dso: Move dso functions out of dsos
> perf dsos: Switch more loops to dsos__for_each_dso
> perf dsos: Switch backing storage to array from rbtree/list
> perf dsos: Remove __dsos__addnew
> perf dsos: Remove __dsos__findnew_link_by_longname_id
> perf dsos: Switch hand code to bsearch
> perf dso: Add reference count checking and accessor functions
> perf dso: Reference counting related fixes
> perf dso: Use container_of to avoid a pointer in dso_data
>
> tools/perf/arch/x86/tests/dwarf-unwind.c | 1 +
> tools/perf/builtin-annotate.c | 8 +-
> tools/perf/builtin-buildid-cache.c | 2 +-
> tools/perf/builtin-buildid-list.c | 18 +-
> tools/perf/builtin-inject.c | 96 +-
> tools/perf/builtin-kallsyms.c | 2 +-
> tools/perf/builtin-mem.c | 4 +-
> tools/perf/builtin-record.c | 2 +-
> tools/perf/builtin-report.c | 209 +--
> tools/perf/builtin-script.c | 8 +-
> tools/perf/builtin-top.c | 4 +-
> tools/perf/builtin-trace.c | 43 +-
> tools/perf/tests/code-reading.c | 8 +-
> tools/perf/tests/dso-data.c | 67 +-
> tools/perf/tests/hists_common.c | 6 +-
> tools/perf/tests/hists_cumulate.c | 4 +-
> tools/perf/tests/hists_output.c | 2 +-
> tools/perf/tests/maps.c | 7 +-
> tools/perf/tests/symbols.c | 2 +-
> tools/perf/tests/thread-maps-share.c | 8 +-
> tools/perf/tests/vmlinux-kallsyms.c | 16 +-
> tools/perf/ui/browsers/annotate.c | 6 +-
> tools/perf/ui/browsers/hists.c | 8 +-
> tools/perf/ui/browsers/map.c | 4 +-
> tools/perf/util/Build | 1 +
> tools/perf/util/annotate-data.c | 6 +-
> tools/perf/util/annotate.c | 45 +-
> tools/perf/util/auxtrace.c | 2 +-
> tools/perf/util/block-info.c | 2 +-
> tools/perf/util/bpf-event.c | 9 +-
> tools/perf/util/bpf_lock_contention.c | 8 +-
> tools/perf/util/build-id.c | 136 +-
> tools/perf/util/build-id.h | 2 -
> tools/perf/util/callchain.c | 4 +-
> tools/perf/util/data-convert-json.c | 2 +-
> tools/perf/util/db-export.c | 6 +-
> tools/perf/util/dlfilter.c | 12 +-
> tools/perf/util/dso.c | 469 +++---
> tools/perf/util/dso.h | 549 ++++++-
> tools/perf/util/dsos.c | 529 ++++---
> tools/perf/util/dsos.h | 40 +-
> tools/perf/util/event.c | 12 +-
> tools/perf/util/header.c | 8 +-
> tools/perf/util/hist.c | 4 +-
> tools/perf/util/intel-pt.c | 22 +-
> tools/perf/util/machine.c | 570 +++-----
> tools/perf/util/machine.h | 32 +-
> tools/perf/util/map.c | 73 +-
> tools/perf/util/maps.c | 1298 +++++++++++------
> tools/perf/util/maps.h | 65 +-
> tools/perf/util/probe-event.c | 26 +-
> tools/perf/util/rb_resort.h | 5 -
> .../util/scripting-engines/trace-event-perl.c | 6 +-
> .../scripting-engines/trace-event-python.c | 21 +-
> tools/perf/util/session.c | 21 +
> tools/perf/util/session.h | 2 +
> tools/perf/util/sort.c | 19 +-
> tools/perf/util/srcline.c | 65 +-
> tools/perf/util/symbol-elf.c | 132 +-
> tools/perf/util/symbol.c | 217 +--
> tools/perf/util/symbol_fprintf.c | 4 +-
> tools/perf/util/synthetic-events.c | 24 +-
> tools/perf/util/thread.c | 8 +-
> tools/perf/util/thread.h | 6 -
> tools/perf/util/threads.c | 186 +++
> tools/perf/util/threads.h | 35 +
> tools/perf/util/unwind-libunwind-local.c | 20 +-
> tools/perf/util/unwind-libunwind.c | 9 +-
> tools/perf/util/vdso.c | 56 +-
> 69 files changed, 3143 insertions(+), 2160 deletions(-)
> create mode 100644 tools/perf/util/threads.c
> create mode 100644 tools/perf/util/threads.h
>
> --
> 2.43.0.594.gd9cf4e227d-goog
>
>
Powered by blists - more mailing lists