linux-kernel - Re: [PATCH 08/18] mfd: khadas-mcu: convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e47aa27-b28d-4672-a2eb-f906e0e6a5ac@linaro.org>
Date: Tue, 6 Feb 2024 09:47:49 +0100
From: neil.armstrong@...aro.org
To: Bo Liu <liubo03@...pur.com>, lee@...nel.org, wens@...e.org,
 marek.vasut+renesas@...il.com, support.opensource@...semi.com,
 ckeepax@...nsource.cirrus.com, rf@...nsource.cirrus.com,
 mazziesaccount@...il.com, mcoquelin.stm32@...il.com,
 alexandre.torgue@...s.st.com
Cc: linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 linux-amlogic@...ts.infradead.org, patches@...nsource.cirrus.com,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 08/18] mfd: khadas-mcu: convert to use maple tree register
 cache

On 06/02/2024 08:13, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Bo Liu <liubo03@...pur.com>
> ---
>   drivers/mfd/khadas-mcu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/khadas-mcu.c b/drivers/mfd/khadas-mcu.c
> index 61396d824f16..ba981a788692 100644
> --- a/drivers/mfd/khadas-mcu.c
> +++ b/drivers/mfd/khadas-mcu.c
> @@ -72,7 +72,7 @@ static const struct regmap_config khadas_mcu_regmap_config = {
>   	.max_register	= KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG,
>   	.volatile_reg	= khadas_mcu_reg_volatile,
>   	.writeable_reg	= khadas_mcu_reg_writeable,
> -	.cache_type	= REGCACHE_RBTREE,
> +	.cache_type	= REGCACHE_MAPLE,
>   };
>   
>   static struct mfd_cell khadas_mcu_fan_cells[] = {

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>