linux-kernel - Re: [PATCH v6 4/4] PCI: Move devres code from pci.c to devres.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20c967ffac2cec6c9d89017d606967551b30d20d.camel@redhat.com>
Date: Tue, 06 Feb 2024 10:37:47 +0100
From: Philipp Stanner <pstanner@...hat.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Arnd Bergmann <arnd@...db.de>, 
 Johannes Berg <johannes@...solutions.net>, Randy Dunlap
 <rdunlap@...radead.org>, NeilBrown <neilb@...e.de>,  John Sanpe
 <sanpeqf@...il.com>, Kent Overstreet <kent.overstreet@...il.com>, Niklas
 Schnelle <schnelle@...ux.ibm.com>, Dave Jiang <dave.jiang@...el.com>,
 Uladzislau Koshchanka <koshchanka@...il.com>, "Masami Hiramatsu (Google)"
 <mhiramat@...nel.org>, David Gow <davidgow@...gle.com>, Kees Cook
 <keescook@...omium.org>, Rae Moar <rmoar@...gle.com>, Geert Uytterhoeven
 <geert@...ux-m68k.org>, "wuqiang.matt" <wuqiang.matt@...edance.com>, Yury
 Norov <yury.norov@...il.com>, Jason Baron <jbaron@...mai.com>, Thomas
 Gleixner <tglx@...utronix.de>, Marco Elver <elver@...gle.com>, Andrew
 Morton <akpm@...ux-foundation.org>, Ben Dooks <ben.dooks@...ethink.co.uk>,
 dakr@...hat.com, linux-kernel@...r.kernel.org,  linux-pci@...r.kernel.org,
 linux-arch@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v6 4/4] PCI: Move devres code from pci.c to devres.c

On Wed, 2024-01-31 at 15:12 -0600, Bjorn Helgaas wrote:
> On Wed, Jan 31, 2024 at 10:00:23AM +0100, Philipp Stanner wrote:
> > The file pci.c is very large and contains a number of devres-
> > functions.
> > These functions should now reside in devres.c
> > ...
> 
> > +struct pci_devres *find_pci_dr(struct pci_dev *pdev)
> > +{
> > +       if (pci_is_managed(pdev))
> > +               return devres_find(&pdev->dev, pcim_release, NULL,
> > NULL);
> > +       return NULL;
> > +}
> > +EXPORT_SYMBOL(find_pci_dr);
> 
> find_pci_dr() was not previously exported, and I don't think it needs
> to be exported now, so I dropped the EXPORT_SYMBOL.  It's still
> usable
> inside drivers/pci since it's declared in drivers/pci/pci.h; it's
> just
> not usable from modules.  Let me know if I missed something.

No, ACK, you are right.
I forgot this since find_pci_dr() is removed later anyways.


P.


> 
> > -static struct pci_devres *find_pci_dr(struct pci_dev *pdev)
> > -{
> > -       if (pci_is_managed(pdev))
> > -               return devres_find(&pdev->dev, pcim_release, NULL,
> > NULL);
> > -       return NULL;
> > -}
>