linux-kernel - Re: [PATCH 10/18] mfd: wolfson: convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcIEFxh76TTXBTiT@ediswmail9.ad.cirrus.com>
Date: Tue, 6 Feb 2024 10:04:07 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Bo Liu <liubo03@...pur.com>
CC: <lee@...nel.org>, <wens@...e.org>, <marek.vasut+renesas@...il.com>,
        <support.opensource@...semi.com>, <neil.armstrong@...aro.org>,
        <rf@...nsource.cirrus.com>, <mazziesaccount@...il.com>,
        <mcoquelin.stm32@...il.com>, <alexandre.torgue@...s.st.com>,
        <linux-kernel@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>,
        <linux-amlogic@...ts.infradead.org>, <patches@...nsource.cirrus.com>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 10/18] mfd: wolfson: convert to use maple tree register
 cache

On Tue, Feb 06, 2024 at 02:13:06AM -0500, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Bo Liu <liubo03@...pur.com>
> ---
>  drivers/mfd/wm5102-tables.c | 2 +-
>  drivers/mfd/wm5110-tables.c | 2 +-
>  drivers/mfd/wm8350-regmap.c | 2 +-
>  drivers/mfd/wm8400-core.c   | 2 +-
>  drivers/mfd/wm97xx-core.c   | 6 +++---
>  5 files changed, 7 insertions(+), 7 deletions(-)

The change looks good, but whilst it won't cause any problems, it
seems a bit weird not to convert wm8997, wm8998 and cs47l24.
These are part of the same driver as wm5102 and wm5110.

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles