linux-kernel - Re: [PATCH v11] bus: mhi: host: Add tracing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5af1ed27-2c59-4d8e-90cb-9ca7a2184b92@quicinc.com>
Date: Tue, 6 Feb 2024 18:15:03 +0530
From: Naman Jain <quic_namajain@...cinc.com>
To: Krishna chaitanya chundru <quic_krichai@...cinc.com>,
        "Manivannan
 Sadhasivam" <mani@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        "Masami
 Hiramatsu" <mhiramat@...nel.org>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>
CC: <linux-kernel@...r.kernel.org>, <mhi@...ts.linux.dev>,
        <linux-arm-msm@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>,
        <quic_vbadigan@...cinc.com>, <quic_ramkri@...cinc.com>,
        <quic_nitegupt@...cinc.com>, <quic_skananth@...cinc.com>,
        <quic_parass@...cinc.com>
Subject: Re: [PATCH v11] bus: mhi: host: Add tracing support

On 2/6/2024 10:02 AM, Krishna chaitanya chundru wrote:
> This change adds ftrace support for following functions which
> helps in debugging the issues when there is Channel state & MHI
> state change and also when we receive data and control events:

Please write commit msg in imperative mood.
https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html#describe-your-changes

> 1. mhi_intvec_mhi_states
> 2. mhi_process_data_event_ring
> 3. mhi_process_ctrl_ev_ring
> 4. mhi_gen_tre
> 5. mhi_update_channel_state
> 6. mhi_tryset_pm_state
> 7. mhi_pm_st_worker
> 
> Change the implementation of the arrays which has enum to strings mapping
> to make it consistent in both trace header file and other files.
> 
> Where ever the trace events are added, debug messages are removed.

Ditto.

Regards,
Naman