linux-kernel - Re: [PATCH v9 2/5] dt-bindings: clock: sophgo: add RP gate clocks for SG2042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB2822C8930916B90A9C1BAA49FE462@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Tue, 6 Feb 2024 20:57:27 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Rob Herring <robh@...nel.org>, Chen Wang <unicornxw@...il.com>
Cc: aou@...s.berkeley.edu, chao.wei@...hgo.com, conor@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, mturquette@...libre.com,
 palmer@...belt.com, paul.walmsley@...ive.com, richardcochran@...il.com,
 sboyd@...nel.org, devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 haijiao.liu@...hgo.com, xiaoguang.xing@...hgo.com, guoren@...nel.org,
 jszhang@...nel.org, inochiama@...look.com, samuel.holland@...ive.com
Subject: Re: [PATCH v9 2/5] dt-bindings: clock: sophgo: add RP gate clocks for
 SG2042


On 2024/2/6 1:24, Rob Herring wrote:
> On Fri, Feb 02, 2024 at 02:42:02PM +0800, Chen Wang wrote:
>> From: Chen Wang <unicorn_wang@...look.com>
>>
>> Add bindings for the gate clocks of RP subsystem for Sophgo SG2042.
>>
>> Signed-off-by: Chen Wang <unicorn_wang@...look.com>
>> ---
>>   .../bindings/clock/sophgo,sg2042-rpgate.yaml  | 37 ++++++++++++
>>   .../dt-bindings/clock/sophgo,sg2042-rpgate.h  | 58 +++++++++++++++++++
>>   2 files changed, 95 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/clock/sophgo,sg2042-rpgate.yaml
>>   create mode 100644 include/dt-bindings/clock/sophgo,sg2042-rpgate.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/sophgo,sg2042-rpgate.yaml b/Documentation/devicetree/bindings/clock/sophgo,sg2042-rpgate.yaml
>> new file mode 100644
>> index 000000000000..69ce3a64f66c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/sophgo,sg2042-rpgate.yaml
>> @@ -0,0 +1,37 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/sophgo,sg2042-rpgate.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Sophgo SG2042 Gate Clock Generator for RP(riscv processors) subsystem
>> +
>> +maintainers:
>> +  - Chen Wang <unicorn_wang@...look.com>
>> +
>> +properties:
>> +  compatible:
>> +    const: sophgo,sg2042-rpgate
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  '#clock-cells':
>> +    const: 1
>> +    description:
>> +      See <dt-bindings/clock/sophgo,sg2042-rpgate.h> for valid indices.
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - '#clock-cells'
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    clock-controller@...00000 {
>> +      compatible = "sophgo,sg2042-rpgate";
>> +      reg = <0x10000000 0x10000>;
>> +      #clock-cells = <1>;
> No input clocks?

I think it should have some input, I will add it, thanks.

BTW,  can we ignore this property if driver doesn't use it？ In other 
words, do we have to add this clocks property just to indicate that this 
node requires some clocks as input from a hardware perspective?

>
>> +    };
>> diff --git a/include/dt-bindings/clock/sophgo,sg2042-rpgate.h b/include/dt-bindings/clock/sophgo,sg2042-rpgate.h
>> new file mode 100644
>> index 000000000000..8b4522d5f559
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/sophgo,sg2042-rpgate.h
>> @@ -0,0 +1,58 @@
>> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
>> +/*
>> + * Copyright (C) 2023 Sophgo Technology Inc. All rights reserved.
>> + */
>> +
>> +#ifndef __DT_BINDINGS_SOPHGO_SG2042_RPGATE_H__
>> +#define __DT_BINDINGS_SOPHGO_SG2042_RPGATE_H__
>> +
>> +#define GATE_CLK_RXU0			0
>> +#define GATE_CLK_RXU1			1
>> +#define GATE_CLK_RXU2			2
>> +#define GATE_CLK_RXU3			3
>> +#define GATE_CLK_RXU4			4
>> +#define GATE_CLK_RXU5			5
>> +#define GATE_CLK_RXU6			6
>> +#define GATE_CLK_RXU7			7
>> +#define GATE_CLK_RXU8			8
>> +#define GATE_CLK_RXU9			9
>> +#define GATE_CLK_RXU10			10
>> +#define GATE_CLK_RXU11			11
>> +#define GATE_CLK_RXU12			12
>> +#define GATE_CLK_RXU13			13
>> +#define GATE_CLK_RXU14			14
>> +#define GATE_CLK_RXU15			15
>> +#define GATE_CLK_RXU16			16
>> +#define GATE_CLK_RXU17			17
>> +#define GATE_CLK_RXU18			18
>> +#define GATE_CLK_RXU19			19
>> +#define GATE_CLK_RXU20			20
>> +#define GATE_CLK_RXU21			21
>> +#define GATE_CLK_RXU22			22
>> +#define GATE_CLK_RXU23			23
>> +#define GATE_CLK_RXU24			24
>> +#define GATE_CLK_RXU25			25
>> +#define GATE_CLK_RXU26			26
>> +#define GATE_CLK_RXU27			27
>> +#define GATE_CLK_RXU28			28
>> +#define GATE_CLK_RXU29			29
>> +#define GATE_CLK_RXU30			30
>> +#define GATE_CLK_RXU31			31
>> +#define GATE_CLK_MP0			32
>> +#define GATE_CLK_MP1			33
>> +#define GATE_CLK_MP2			34
>> +#define GATE_CLK_MP3			35
>> +#define GATE_CLK_MP4			36
>> +#define GATE_CLK_MP5			37
>> +#define GATE_CLK_MP6			38
>> +#define GATE_CLK_MP7			39
>> +#define GATE_CLK_MP8			40
>> +#define GATE_CLK_MP9			41
>> +#define GATE_CLK_MP10			42
>> +#define GATE_CLK_MP11			43
>> +#define GATE_CLK_MP12			44
>> +#define GATE_CLK_MP13			45
>> +#define GATE_CLK_MP14			46
>> +#define GATE_CLK_MP15			47
>> +
>> +#endif /* __DT_BINDINGS_SOPHGO_SG2042_RPGATE_H__ */
>> -- 
>> 2.25.1
>>