linux-kernel - Re: [PATCH v4 0/2] drm: Check polling initialized before

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcI9Mw-MclTtkbwe@phenom.ffwll.local>
Date: Tue, 6 Feb 2024 15:07:47 +0100
From: Daniel Vetter <daniel@...ll.ch>
To: Shradha Gupta <shradhagupta@...ux.microsoft.com>
Cc: linux-kernel@...r.kernel.org,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.dev>,
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
	dri-devel@...ts.freedesktop.org,
	Saurabh Singh Sengar <ssengar@...ux.microsoft.com>,
	Shradha Gupta <shradhagupta@...rosoft.com>
Subject: Re: [PATCH v4 0/2] drm: Check polling initialized before

On Thu, Feb 01, 2024 at 10:42:56PM -0800, Shradha Gupta wrote:
> This patchset consists of sanity checks before enabling/disabling
> output polling to make sure we do not call polling enable and disable
> functions when polling for the device is not initialized or is now
> uninitialized(by drm_kms_helper_poll_fini() function)
> 
> The first patch consists of these checks in
> drm_kms_helper_poll_disable() and drm_kms_helper_poll_enable() calls.
> It further flags a warning if a caller violates this. It also adds
> these checks in drm_mode_config_helper_resume() and
> drm_mode_config_helper_suspend() calls to avoid this warning.
> 
> The second patch adds a similar missing check in
> drm_helper_probe_single_connector_modes() function that is exposed by
> the new warning introduced in the first patch.
> 
> Shradha Gupta (2):
>   drm: Check output polling initialized before disabling
>   drm: Check polling initialized before enabling in
>     drm_helper_probe_single_connector_modes

On the series:

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>

> 
>  drivers/gpu/drm/drm_modeset_helper.c | 19 ++++++++++++++++---
>  drivers/gpu/drm/drm_probe_helper.c   | 21 +++++++++++++++++----
>  2 files changed, 33 insertions(+), 7 deletions(-)
> 
> -- 
> 2.34.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch