linux-kernel - Re: [PATCH v4 2/4] sched/fair: remove unused parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240207162255.GB21939@ranerica-svr.sc.intel.com>
Date: Wed, 7 Feb 2024 08:22:55 -0800
From: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
To: alexs@...nel.org
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
	Juri Lelli <juri.lelli@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>,
	Daniel Bristot de Oliveira <bristot@...hat.com>,
	Valentin Schneider <vschneid@...hat.com>,
	linux-kernel@...r.kernel.org, yangyicong@...ilicon.com
Subject: Re: [PATCH v4 2/4] sched/fair: remove unused parameters

On Wed, Feb 07, 2024 at 11:47:02AM +0800, alexs@...nel.org wrote:
> From: Alex Shi <alexs@...nel.org>

A few nits:

subject: s/remove/Remove/

> 
> sds isn't used in function sched_asym(), so remove it to cleanup code.

The argument sds is not used in function sched_asym(). Remove it.

> 
> Fixes: c9ca07886aaa ("sched/fair: Do not even the number of busy CPUs via asym_packing")
> Signed-off-by: Alex Shi <alexs@...nel.org>
> Reviewed-by: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>

With that, my tag stands, FWIW.