linux-kernel - Re: [PATCH] ASoC: cs35l56: Fix deadlock in ASP1 mixer register initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZcOvREgHBiQVuB9n@finisterre.sirena.org.uk>
Date: Wed, 7 Feb 2024 16:26:44 +0000
From: Mark Brown <broonie@...nel.org>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: alsa-devel@...a-project.org, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH] ASoC: cs35l56: Fix deadlock in ASP1 mixer register
 initialization

On Wed, Feb 07, 2024 at 04:16:02PM +0000, Richard Fitzgerald wrote:

> +	if (!cs35l56->asp1_mixer_widgets_initialized) {
> +		ret = cs35l56_sync_asp1_mixer_widgets_with_firmware(cs35l56);
> +		if (ret)
> +			return ret;
> +	}

Might it make sense to factor the check for init into the function since
it looks like all the callers do it and I'd expect that'd be the case
for any new ones?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)