linux-kernel - Re: [PATCH v3 1/3] iommu/iova: Tidy up iova_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bpw77hrrerzmhxk3jkw2b44cupnusddqqnrjaj2jjq7w2zukpr@ghcbjhexqxqw>
Date: Wed, 7 Feb 2024 09:38:36 -0700
From: Jerry Snitselaar <jsnitsel@...hat.com>
To: Robin Murphy <robin.murphy@....com>
Cc: joro@...tes.org, will@...nel.org, pasha.tatashin@...een.com, 
	iommu@...ts.linux.dev, linux-kernel@...r.kernel.org, linux-mm@...ck.org, 
	rientjes@...gle.com, yosryahmed@...gle.com, john.g.garry@...cle.com
Subject: Re: [PATCH v3 1/3] iommu/iova: Tidy up iova_cache_get() failure

On Mon, Feb 05, 2024 at 03:32:39PM +0000, Robin Murphy wrote:
> Failure handling in iova_cache_get() is a little messy, and we'd like
> to add some more to it, so let's tidy up a bit first. By leaving the
> hotplug handler until last we can take advantage of kmem_cache_destroy()
> being NULL-safe to have a single cleanup label. We can also improve the
> error reporting, noting that kmem_cache_create() already screams if it
> fails, so that one is redundant.
> 
> Signed-off-by: Robin Murphy <robin.murphy@....com>
> ---
>  drivers/iommu/iova.c | 33 ++++++++++++++++-----------------
>  1 file changed, 16 insertions(+), 17 deletions(-)
> 

Reviewed-by: Jerry Snitselaar <jsnitsel@...hat.com>