linux-kernel - Re: [PATCH] ALSA: hda/realtek: cs35l41: Fix device ID / model name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a5oc5hel.wl-tiwai@suse.de>
Date: Wed, 07 Feb 2024 18:10:58 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Jean-Loïc Charroud <lagiraudiere+linux@...e.fr>
Cc: Takashi Iwai <tiwai@...e.de>,
	Stefan Binding <sbinding@...nsource.cirrus.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Richard Fitzgerald <rf@...nsource.cirrus.com>,
	linux-sound <linux-sound@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	patches <patches@...nsource.cirrus.com>
Subject: Re: [PATCH] ALSA: hda/realtek: cs35l41: Fix device ID / model name

On Wed, 07 Feb 2024 17:51:51 +0100,
Jean-Loïc Charroud wrote:
> 
> (un)swap device ID for "ASUS UM3402" and "ASUS UM6702RA/RC".

You need to explain why it's needed.  Was it wrongly done?  Or for
what purpose you swap?

And, here you need to give "Fixes:" tag pointing to the commit that
introduced the change / line.  In this case, it was 51d976079976
("ALSA: hda/realtek: Add quirks for ASUS Zenbook 2022 Models").
It modified the entry 1043:1e2e from "ASUS UM3402" to "ASUS
UM6702RA/RC" and add another entry for "ASUS UM3402" with 104e:1ee2.

thanks,

Takashi