linux-kernel - Re: [PATCH net-next v6 4/4] eventpoll: Add epoll ioctl for epoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 7 Feb 2024 11:07:26 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Joe Damato <jdamato@...tly.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 chuck.lever@...cle.com, jlayton@...nel.org, linux-api@...r.kernel.org,
 brauner@...nel.org, edumazet@...gle.com, davem@...emloft.net,
 alexander.duyck@...il.com, sridhar.samudrala@...el.com,
 willemdebruijn.kernel@...il.com, weiwan@...gle.com,
 David.Laight@...LAB.COM, arnd@...db.de, sdf@...gle.com,
 amritha.nambiar@...el.com, Jonathan Corbet <corbet@....net>, Alexander Viro
 <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, Nathan Lynch
 <nathanl@...ux.ibm.com>, Michael Ellerman <mpe@...erman.id.au>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Namjae Jeon
 <linkinjeon@...nel.org>, Steve French <stfrench@...rosoft.com>, Thomas
 Zimmermann <tzimmermann@...e.de>, Julien Panis <jpanis@...libre.com>,
 Andrew Waterman <waterman@...s.berkeley.edu>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, "open
 list:DOCUMENTATION" <linux-doc@...r.kernel.org>, "open list:FILESYSTEMS
 (VFS and infrastructure)" <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH net-next v6 4/4] eventpoll: Add epoll ioctl for
 epoll_params

On Wed, 7 Feb 2024 10:50:15 -0800 Joe Damato wrote:
> > This !! is unnecessary. Nonzero values shall be "converted" to true.
> > 
> > But FWIW, the above is nothing which should be blocking, so:
> "> 
> > Reviewed-by: Jiri Slaby <jirislaby@...nel.org>  
> 
> netdev maintainers: Jiri marked this with Reviewed-by, but was this review
> what caused "Changes Requested" to be the status set for this patch set in
> patchwork?
> 
> If needed, I'll send a v7 with the changes Jiri suggested and add the
> "Reviewed-by" since the changes are cosmetic, but I wanted to make sure
> this was the reason.

Yes, I think that's it.