linux-kernel - Re: [PATCH 2/2] platform/chrome: cros_ec_typec: Make sure the USB role switch has PLD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <338756c8-af83-c023-c5b7-757d57c76fa2@gmail.com>
Date: Wed, 7 Feb 2024 22:14:54 +0300
From: Sergei Shtylyov <sergei.shtylyov@...il.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Prashant Malani <pmalani@...omium.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Benson Leung <bleung@...omium.org>, Tzung-Bi Shih <tzungbi@...nel.org>,
 Guenter Roeck <groeck@...omium.org>, Emilie Roberts <hadrosaur@...gle.com>,
 "Nyman, Mathias" <mathias.nyman@...el.com>,
 "Regupathy, Rajaram" <rajaram.regupathy@...el.com>,
 "Radjacoumar, Shyam Sundar" <ssradjacoumar@...gle.com>,
 Samuel Jacob <samjaco@...gle.com>, linux-usb@...r.kernel.org,
 chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Uday Bhat <uday.m.bhat@...el.com>
Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_typec: Make sure the USB
 role switch has PLD

On 2/7/24 5:58 PM, Heikki Krogerus wrote:

> The USB role switch does not always have the _PLD (Physical
> Location of Device) in ACPI tables. If it's missing,
> assigning the PLD hash of the port to the switch. That
> should guarantee that the USB Type-C port mapping code is
> always able to find the connection between the two (the port
> and the switch).
> 
> Tested-by: Uday Bhat <uday.m.bhat@...el.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
>  drivers/platform/chrome/cros_ec_typec.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 2b2f14a1b711..5c14e8db08b5 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
[...]
> @@ -66,6 +67,16 @@ static int cros_typec_parse_port_props(struct typec_capability *cap,
>  		cap->prefer_role = ret;
>  	}
>  
> +	/* Assing the USB role switch the correct pld_crc if it's missing. */

   Doing what?! :-P Maybe assign?

[...]

MBR, Sergey