linux-kernel - Re: [PATCH net-next v6 1/4] eventpoll: support busy poll per epoll instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240207125628.44c5d732@kernel.org>
Date: Wed, 7 Feb 2024 12:56:28 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Joe Damato <jdamato@...tly.com>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 chuck.lever@...cle.com, jlayton@...nel.org, linux-api@...r.kernel.org,
 brauner@...nel.org, edumazet@...gle.com, davem@...emloft.net,
 alexander.duyck@...il.com, sridhar.samudrala@...el.com,
 willemdebruijn.kernel@...il.com, weiwan@...gle.com,
 David.Laight@...LAB.COM, arnd@...db.de, sdf@...gle.com,
 amritha.nambiar@...el.com, Alexander Viro <viro@...iv.linux.org.uk>, Jan
 Kara <jack@...e.cz>, "open list:FILESYSTEMS (VFS and infrastructure)"
 <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH net-next v6 1/4] eventpoll: support busy poll per epoll
 instance

On Wed, 7 Feb 2024 12:23:23 -0800 Joe Damato wrote:
> > Unless you have a clear reason not to, I think using u32 would be more
> > natural? If my head math is right the range for u32 is 4096 sec,
> > slightly over an hour? I'd use u32 and limit it to S32_MAX.  
> 
> OK, that seems fine. Sorry for the noob question, but since that represents
> a fucntional change to patch 4/4, I believe I would need to drop Jiri's
> Reviewed-by, is that right?

I'd default to keeping it. But the review tag retention rules are one
of the more subjective things in kernel developments.