linux-kernel - Re: [PATCH][next] carl9170: Remove redundant assignment to pointer super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41ac1eca-ff9c-4a1c-be53-f37aca8aa178@gmail.com>
Date: Wed, 7 Feb 2024 22:32:57 +0100
From: Christian Lamparter <chunkeey@...il.com>
To: Colin Ian King <colin.i.king@...il.com>, Kalle Valo <kvalo@...nel.org>,
 linux-wireless@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] carl9170: Remove redundant assignment to pointer
 super

On 2/7/24 18:15, Colin Ian King wrote:
> The pointer super is being assigned a value that is not being read, it
> is being re-assigned later. The assignment is redundant and can be
> removed.
> 
> Cleans up clang scan warning:
> drivers/net/wireless/ath/carl9170/tx.c:192:34: warning: Value stored to
> 'super' during its initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
Acked-by: Christian Lamparter <chunkeey@...il.com>

> ---
>   drivers/net/wireless/ath/carl9170/tx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/carl9170/tx.c b/drivers/net/wireless/ath/carl9170/tx.c
> index 6bb9aa2bfe65..e902ca80eba7 100644
> --- a/drivers/net/wireless/ath/carl9170/tx.c
> +++ b/drivers/net/wireless/ath/carl9170/tx.c
> @@ -189,7 +189,7 @@ static void carl9170_tx_accounting_free(struct ar9170 *ar, struct sk_buff *skb)
>   
>   static int carl9170_alloc_dev_space(struct ar9170 *ar, struct sk_buff *skb)
>   {
> -	struct _carl9170_tx_superframe *super = (void *) skb->data;
> +	struct _carl9170_tx_superframe *super;
>   	unsigned int chunks;
>   	int cookie = -1;
>