linux-kernel - Re: [PATCH] ASoC: tas2781: remove unused acpi_subysystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 08 Feb 2024 00:24:22 +0100
From: Gergo Koteles <soyer@....hu>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Shenghao Ding <shenghao-ding@...com>, Kevin Lu <kevin-lu@...com>,
  Baojun Xu <baojun.xu@...com>, Jaroslav Kysela <perex@...ex.cz>,
  Takashi Iwai <tiwai@...e.com>, Liam Girdwood <lgirdwood@...il.com>,
  Mark Brown <broonie@...nel.org>, linux-sound@...r.kernel.org,
  linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
  stable@...r.kernel.org
Subject: Re: [PATCH] ASoC: tas2781: remove unused acpi_subysystem_id

Hi Greg,

On Wed, 2024-02-07 at 10:02 +0000, Greg KH wrote:
> On Tue, Feb 06, 2024 at 09:25:50PM +0100, Gergo Koteles wrote:
> > The acpi_subysystem_id is only written and freed, not read, so
> > unnecessary.
> > 
> > Fixes: ef3bcde75d06 ("ASoC: tas2781: Add tas2781 driver")
> 
> What does this really "fix"?  It's just a cleanup.
> 
> > CC: stable@...r.kernel.org
> 
> Again, what bug is this fixing?
> 
> Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> about what should be tagged for stable kernels, which this patch series
> does not seem to fix.
> 

Yes, you are right, this is not really a bug.
I took the scope of "oh, that's not good" too wide.
Sorry for the noise.

thanks,
Gergo