linux-kernel - Re: next: /dev/root: Can't open blockdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef44e0d9-a4a5-4fbd-9db9-7644ede2e30d@amd.com>
Date: Wed, 7 Feb 2024 09:46:24 +0530
From: "Aithal, Srikanth" <sraithal@....com>
To: Marek Szyprowski <m.szyprowski@...sung.com>,
 Christian Brauner <brauner@...nel.org>,
 Naresh Kamboju <naresh.kamboju@...aro.org>
Cc: Jan Kara <jack@...e.cz>, linux-block <linux-block@...r.kernel.org>,
 Linux-Next Mailing List <linux-next@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>,
 Linux Regressions <regressions@...ts.linux.dev>,
 linux-fsdevel@...r.kernel.org, lkft-triage@...ts.linaro.org,
 Arnd Bergmann <arnd@...db.de>, Dan Carpenter <dan.carpenter@...aro.org>,
 Al Viro <viro@...iv.linux.org.uk>, Anders Roxell <anders.roxell@...aro.org>
Subject: Re: next: /dev/root: Can't open blockdev

On 2/7/2024 4:35 AM, Marek Szyprowski wrote:
> Hi Christian,
> 
> On 06.02.2024 16:53, Christian Brauner wrote:
>>> On it.
>> Ok, can you try:
>> git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.super.debug
>> please?
> 
> 
> I've also encountered this issue during my linux-next daily tests and I
> confirm that the above branch works fine.
> 
> 
> I've applied the diff between e3bfad989976^2 and the above branch
> (bc7cb6c829e2), which looks following:
> 
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index 279ad28bf4fb..d8ea839463a5 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -19,6 +19,7 @@
>    #include <linux/ramfs.h>
>    #include <linux/shmem_fs.h>
>    #include <linux/ktime.h>
> +#include <linux/task_work.h>
> 
>    #include <linux/nfs_fs.h>
>    #include <linux/nfs_fs_sb.h>
> @@ -208,6 +209,10 @@ void __init mount_root_generic(char *name, char
> *pretty_name, int flags)
>                                   goto out;
>                           case -EACCES:
>                           case -EINVAL:
> +#ifdef CONFIG_BLOCK
> +                               flush_delayed_fput();
> +                               task_work_run();
> +#endif
>                                   continue;
>                   }
>                   /*
> 
> 
> onto next-20240206 and it fixed all boot problems I've observed on my
> test farm. :)
> 
> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>
> 
> Best regards

We as well encountered this issue during our CI run. The given branch 
fixes the issues seen in our run.

Tested-by: Srikanth Aithal <sraithal@....com>