linux-kernel - RE: [PATCH 1/3] dm integrity: do not filter algos with CRYPTO_ALG_ALLOCATES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 7 Feb 2024 06:22:06 +0000
From: Meenakshi Aggarwal <meenakshi.aggarwal@....com>
To: Herbert Xu <herbert@...dor.apana.org.au>, Giovanni Cabiddu
	<giovanni.cabiddu@...el.com>
CC: Eric Biggers <ebiggers@...nel.org>, "agk@...hat.com" <agk@...hat.com>,
	"snitzer@...nel.org" <snitzer@...nel.org>, "linux-crypto@...r.kernel.org"
	<linux-crypto@...r.kernel.org>, "dm-devel@...hat.com" <dm-devel@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"qat-linux@...el.com" <qat-linux@...el.com>, "heinzm@...hat.com"
	<heinzm@...hat.com>, Horia Geanta <horia.geanta@....com>, Varun Sethi
	<V.Sethi@....com>, Pankaj Gupta <pankaj.gupta@....com>, Gaurav Jain
	<gaurav.jain@....com>, "davem@...emloft.net" <davem@...emloft.net>, Iuliana
 Prodan <iuliana.prodan@....com>, Fiona Trahe <fiona.trahe@...el.com>
Subject: RE: [PATCH 1/3] dm integrity: do not filter algos with
 CRYPTO_ALG_ALLOCATES_MEMORY

Hi Herbert,

What are your plans for this change?

Thanks,
Meenakshi

> -----Original Message-----
> From: Herbert Xu <herbert@...dor.apana.org.au>
> Sent: Thursday, July 6, 2023 3:28 AM
> To: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
> Cc: Eric Biggers <ebiggers@...nel.org>; agk@...hat.com; snitzer@...nel.org;
> linux-crypto@...r.kernel.org; dm-devel@...hat.com; linux-
> kernel@...r.kernel.org; qat-linux@...el.com; heinzm@...hat.com; Meenakshi
> Aggarwal <meenakshi.aggarwal@....com>; Horia Geanta
> <horia.geanta@....com>; Varun Sethi <V.Sethi@....com>; Pankaj Gupta
> <pankaj.gupta@....com>; Gaurav Jain <gaurav.jain@....com>;
> davem@...emloft.net; Iuliana Prodan <iuliana.prodan@....com>; Fiona Trahe
> <fiona.trahe@...el.com>
> Subject: Re: [PATCH 1/3] dm integrity: do not filter algos with
> CRYPTO_ALG_ALLOCATES_MEMORY
>
> On Wed, Jul 05, 2023 at 09:57:54PM +0100, Giovanni Cabiddu wrote:
> >
> > Then we are then back to square one. We need to check how many entries
> > are present in the scatterlists encrypted by crypt_journal() before
> > adjusting the meaning of !CRYPTO_ALG_ALLOCATES_MEMORY.
>
> Indeed.  I missed the fact that it was preallocating memory with GFP_KERNEL.
>
> So perhaps the answer is to adjust our API to allow the drivers to pre-allocate
> memory.  I'll look into this.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page:
> http://gondor.ap/
> ana.org.au%2F~herbert%2F&data=05%7C01%7Cmeenakshi.aggarwal%40nxp.co
> m%7C59d63c0b42d5423abb1108db7da2e431%7C686ea1d3bc2b4c6fa92cd99c5
> c301635%7C0%7C0%7C638241910806938399%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> 7C3000%7C%7C%7C&sdata=vdLCyhQOSTEhIK1%2FkAO7Z%2Fu6ejrLbRHwM88N
> DmsqaP0%3D&reserved=0
> PGP Key:
> http://gondor.ap/
> ana.org.au%2F~herbert%2Fpubkey.txt&data=05%7C01%7Cmeenakshi.aggarwal
> %40nxp.com%7C59d63c0b42d5423abb1108db7da2e431%7C686ea1d3bc2b4c6f
> a92cd99c5c301635%7C0%7C0%7C638241910806938399%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%3D%7C3000%7C%7C%7C&sdata=eAkggsD8FaJzb9OO2p1bcaPYs8xt47Eav
> UdVVssGM7o%3D&reserved=0