linux-kernel - [PATCH] bus: mhi: host: free buffer on error in mhi_alloc_bhie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240207065136.18316-1-pchelkin@ispras.ru>
Date: Wed,  7 Feb 2024 09:51:36 +0300
From: Fedor Pchelkin <pchelkin@...ras.ru>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: Fedor Pchelkin <pchelkin@...ras.ru>,
	Jeffrey Hugo <quic_jhugo@...cinc.com>,
	Kalle Valo <quic_kvalo@...cinc.com>,
	Carl Vanderlip <quic_carlv@...cinc.com>,
	Sujeev Dias <sdias@...eaurora.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Siddartha Mohanadoss <smohanad@...eaurora.org>,
	mhi@...ts.linux.dev,
	linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Alexey Khoroshilov <khoroshilov@...ras.ru>,
	lvc-project@...uxtesting.org
Subject: [PATCH] bus: mhi: host: free buffer on error in mhi_alloc_bhie_table

img_info->mhi_buf should be freed on error path in mhi_alloc_bhie_table().
This error case is rare but still needs to be fixed.

Found by Linux Verification Center (linuxtesting.org).

Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>
---
 drivers/bus/mhi/host/boot.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
index edc0ec5a0933..738dcd11b66f 100644
--- a/drivers/bus/mhi/host/boot.c
+++ b/drivers/bus/mhi/host/boot.c
@@ -357,6 +357,7 @@ int mhi_alloc_bhie_table(struct mhi_controller *mhi_cntrl,
 	for (--i, --mhi_buf; i >= 0; i--, mhi_buf--)
 		dma_free_coherent(mhi_cntrl->cntrl_dev, mhi_buf->len,
 				  mhi_buf->buf, mhi_buf->dma_addr);
+	kfree(img_info->mhi_buf);
 
 error_alloc_mhi_buf:
 	kfree(img_info);
-- 
2.39.2