linux-kernel - Re: [PATCH] drivers/ps3: select VIDEO to provide cmdline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 7 Feb 2024 16:31:32 +0900
From: Geoff Levand <geoff@...radead.org>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin
 <npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>,
 "Aneesh Kumar K . V" <aneesh.kumar@...nel.org>,
 "Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>,
 linuxppc-dev@...ts.ozlabs.org, Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH] drivers/ps3: select VIDEO to provide cmdline functions

Hi,

On 2/7/24 12:37, Randy Dunlap wrote:
> When VIDEO is not set, there is a build error. Fix that by selecting
> VIDEO for PS3_PS3AV.
> 
> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined!
> 
> Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Nicholas Piggin <npiggin@...il.com>
> Cc: Christophe Leroy <christophe.leroy@...roup.eu>
> Cc: Aneesh Kumar K.V <aneesh.kumar@...nel.org>
> Cc: Naveen N. Rao <naveen.n.rao@...ux.ibm.com>
> Cc: linuxppc-dev@...ts.ozlabs.org
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Geoff Levand <geoff@...radead.org>
> ---
>  arch/powerpc/platforms/ps3/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -- a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig
> --- a/arch/powerpc/platforms/ps3/Kconfig
> +++ b/arch/powerpc/platforms/ps3/Kconfig
> @@ -67,6 +67,7 @@ config PS3_VUART
>  config PS3_PS3AV
>  	depends on PPC_PS3
>  	tristate "PS3 AV settings driver" if PS3_ADVANCED
> +	select VIDEO
>  	select PS3_VUART
>  	default y
>  	help

Seems good.

Acked-by: Geoff Levand <geoff@...radead.org>