linux-kernel - Re: [PATCH v1 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJRtX8Sj01ENTQ0VRNzwBy+e9qHyJdtUQxWBB1yDCE77-Xb9qw@mail.gmail.com>
Date: Wed, 7 Feb 2024 16:43:19 +0800
From: Jingbao Qiu <qiujingbao.dlmu@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: u.kleine-koenig@...gutronix.de, robh+dt@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, 
	paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu, 
	linux-pwm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	dlan@...too.org, inochiama@...look.com
Subject: Re: [PATCH v1 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC

On Wed, Feb 7, 2024 at 4:09 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 07/02/2024 07:09, Jingbao Qiu wrote:
> > Implement the PWM driver for CV1800.
> >
> > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@...il.com>
> > ---
>
>
> > +
> > +static struct platform_driver cv1800_pwm_driver = {
> > +     .driver = {
> > +             .name = "cv1800-pwm",
> > +             .of_match_table = cv1800_pwm_dt_ids,
> > +     },
> > +     .probe = cv1800_pwm_probe,
> > +};
> > +module_platform_driver(cv1800_pwm_driver);
> > +
> > +MODULE_ALIAS("platform:cv1800-pwm");
>
> You should not need MODULE_ALIAS() in normal cases. If you need it,
> usually it means your device ID table is wrong (e.g. misses either
> entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
> for incomplete ID table.
>

you're right, I will drop it.

Best regards,
Jingbao Qiu