linux-kernel - Re: [PATCH 2/2] iio: accel: adxl367: fix I2C FIFO data register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 07 Feb 2024 10:08:38 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: Cosmin Tanislav <demonsingur@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Cosmin Tanislav
 <cosmin.tanislav@...log.com>,  Jonathan Cameron <jic23@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] iio: accel: adxl367: fix I2C FIFO data register

On Wed, 2024-02-07 at 05:36 +0200, Cosmin Tanislav wrote:
> As specified in the datasheet, the I2C FIFO data register is
> 0x18, not 0x42. 0x42 was used by mistake when adapting the
> ADXL372 driver.
> 
> Fix this mistake.
> 
> Signed-off-by: Cosmin Tanislav <demonsingur@...il.com>
> ---

This needs a Fixes: tag. With that:

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

>  drivers/iio/accel/adxl367_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/adxl367_i2c.c b/drivers/iio/accel/adxl367_i2c.c
> index b595fe94f3a3..62c74bdc0d77 100644
> --- a/drivers/iio/accel/adxl367_i2c.c
> +++ b/drivers/iio/accel/adxl367_i2c.c
> @@ -11,7 +11,7 @@
>  
>  #include "adxl367.h"
>  
> -#define ADXL367_I2C_FIFO_DATA	0x42
> +#define ADXL367_I2C_FIFO_DATA	0x18
>  
>  struct adxl367_i2c_state {
>  	struct regmap *regmap;