linux-kernel - Re: [PATCH v2] nvmem: rmem: Fix return value of rmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024020734-curliness-licking-44c1@gregkh>
Date: Wed, 7 Feb 2024 09:34:02 +0000
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Joy Chakraborty <joychakr@...gle.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Nicolas Saenz Julienne <nsaenz@...nel.org>,
	linux-kernel@...r.kernel.org, manugautam@...gle.com,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] nvmem: rmem: Fix return value of rmem_read()

On Tue, Feb 06, 2024 at 05:22:15PM +0530, Joy Chakraborty wrote:
> > > Userspace will see a false error with nvmem cell reads from
> > > nvmem_cell_attr_read() in current code, which should be fixed on
> > > returning 0 for success.
> >
> > So maybe fix this all up to allow the read to return the actual amount
> > read?  That feels more "correct" to me.
> >
> 
> If I change the behavior of the nvmem_reg_read_t callback to negative
> for error and number of bytes actually read for success then, other
> than the core driver I would also have to change all the
> nvmem-provider drivers.
> Is it okay to do so ?

Sure, why not?  That seems like the correct fix to me, right?

thanks,

greg k-h