linux-kernel - Re: [PATCH] qed: remove duplicated assignment to variable opaque

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240207093911.GM1104779@kernel.org>
Date: Wed, 7 Feb 2024 09:39:11 +0000
From: Simon Horman <horms@...nel.org>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Ariel Elior <aelior@...vell.com>, Manish Chopra <manishc@...vell.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qed: remove duplicated assignment to variable opaque_fid

On Mon, Feb 05, 2024 at 09:55:30PM +0000, Colin Ian King wrote:
> Variable opaque_fid is being assigned twice with the same value
> in two identical statements. Remove the redundant first assignment.
> 
> Cleans up clang scan build warnin:

warning :)

> drivers/net/ethernet/qlogic/qed/qed_rdma.c:1796:2: warning: Value
> stored to 'opaque_fid' is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>