linux-kernel - Re: [PATCH] net/mlx5: remove redundant assignment to variable object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240207094808.GO1104779@kernel.org>
Date: Wed, 7 Feb 2024 09:48:08 +0000
From: Simon Horman <horms@...nel.org>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5: remove redundant assignment to variable
 object_range

On Tue, Feb 06, 2024 at 04:58:15PM +0000, Colin Ian King wrote:
> The variable object_range to log_header_modify_argument_granularity
> is being assigned a value that is never read, the following statement
> assigns object_range to the max of log_header_modify_argument_granularity
> and DR_ICM_MODIFY_HDR_GRANULARITY_4K, so clearly the initial
> assignment is redundant. Remove it.
> 
> Cleans up clang-scan build warning:
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c:42:2: warning:
> Value stored to 'object_range' is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Thanks Colin,

Reviewed-by: Simon Horman <horms@...nel.org>