linux-kernel - Re: [EXTERNAL] Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e61999e6-8c82-40a2-a2b9-e19d636364f5@linaro.org>
Date: Wed, 7 Feb 2024 10:53:28 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: "Ding, Shenghao" <shenghao-ding@...com>,
 "broonie@...nel.org" <broonie@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "robh+dt@...nel.org" <robh+dt@...nel.org>,
 "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
 "linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
 "liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
 "lgirdwood@...il.com" <lgirdwood@...il.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "Lu, Kevin" <kevin-lu@...com>, "Xu, Baojun" <baojun.xu@...com>,
 "P O, Vijeth" <v-po@...com>, "Navada Kanyana, Mukund" <navada@...com>,
 "perex@...ex.cz" <perex@...ex.cz>, "McPherson, Jeff" <j-mcpherson@...com>,
 "pierre-louis.bossart@...ux.intel.com"
 <pierre-louis.bossart@...ux.intel.com>,
 "13916275206@....com" <13916275206@....com>,
 "Chawla, Mohit" <mohit.chawla@...com>, "soyer@....hu" <soyer@....hu>,
 "Huang, Jonathan" <jkhuang3@...com>, "tiwai@...e.de" <tiwai@...e.de>,
 "Djuandi, Peter" <pdjuandi@...com>, "Agrawal, Manisha"
 <manisha.agrawal@...com>, "Hari, Raj" <s-hari@...com>,
 "Yashar, Avi" <aviel@...com>, "Nagalla, Hari" <hnagalla@...com>,
 "Bajjuri, Praneeth" <praneeth@...com>
Subject: Re: [EXTERNAL] Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240: Add
 initial DT binding

On 07/02/2024 10:47, Ding, Shenghao wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> Sent: Tuesday, February 6, 2024 9:53 PM
>> To: Ding, Shenghao <shenghao-ding@...com>; broonie@...nel.org;
>> conor+dt@...nel.org; devicetree@...r.kernel.org; robh+dt@...nel.org;
>> andriy.shevchenko@...ux.intel.com; linux-sound@...r.kernel.org;
>> liam.r.girdwood@...el.com; lgirdwood@...il.com; linux-
>> kernel@...r.kernel.org
>> Cc: Lu, Kevin <kevin-lu@...com>; Xu, Baojun <baojun.xu@...com>; P O, Vijeth
>> <v-po@...com>; Navada Kanyana, Mukund <navada@...com>;
>> perex@...ex.cz; McPherson, Jeff <j-mcpherson@...com>; pierre-
>> louis.bossart@...ux.intel.com; 13916275206@....com; Chawla, Mohit
>> <mohit.chawla@...com>; soyer@....hu; Huang, Jonathan
>> <jkhuang3@...com>; tiwai@...e.de; Djuandi, Peter <pdjuandi@...com>;
>> Agrawal, Manisha <manisha.agrawal@...com>; Hari, Raj <s-hari@...com>;
>> Yashar, Avi <aviel@...com>; Nagalla, Hari <hnagalla@...com>; Bajjuri,
>> Praneeth <praneeth@...com>
>> Subject: [EXTERNAL] Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240: Add
>> initial DT binding
>>
>> On 03/02/2024 04: 05, Shenghao Ding wrote: > + > + ti,tad5212: Low-power
>> stereo audio DAC with 120-dB dynamic range. > + oneOf: > + - items: > + -
>> enum: > + - ti,adc3120 > + - ti,adc5120 > + - ti,pcm3120 > + - ti,pcm5120
>> ZjQcmQRYFpfptBannerStart This message was sent from outside of Texas
>> Instruments.
>> Do not click links or open attachments unless you recognize the source of
>> this email and know the content is safe.
>>
>> ZjQcmQRYFpfptBannerEnd
>> On 03/02/2024 04:05, Shenghao Ding wrote:
>>> +
>>> +      ti,tad5212: Low-power stereo audio DAC with 120-dB dynamic range.
>>> +    oneOf:
>>> +      - items:
>>> +          - enum:
>>> +              - ti,adc3120
>>> +              - ti,adc5120
>>> +              - ti,pcm3120
>>> +              - ti,pcm5120
>>> +              - ti,pcm6120
>>> +          - const: ti,adc6120
>>> +      - items:
>>> +          - enum:
>>> +              - ti,pcm6260
>>> +              - ti,pcm6140
>>> +              - ti,pcm3140
>>> +              - ti,pcm5140
>>> +          - const: ti,pcm6240
>>> +      - items:
>>> +          - const: ti,dix4192
>>> +          - const: ti,pcm6240
>>
>> Why dix4192 is not part of previous enum?
> 
> dix4192 is not traditional ADC or DAC, but an Integrated Digital Audio Interface 
> Receiver and Transmitter, like an audio bridge to connect different digital audio 
> protocol, compatible with the AES3, S/PDIF, IEC 60958, and EIAJ CP-1201 
> interface standards, Left-Justified, Right-Justified, and Philips I2S™ Data Formats. 
> So keep it alone for professional purpose. 

Hm, it is a bit surprising to see some PCM6240-compatible devices 100%
different from other PCM6240-compatible. PCM6240 is ADC. DIX4192 is not
ADC, not even DAC. How can it be compatible with PCM6240 in such case?

Best regards,
Krzysztof