[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <843e34a5-f175-4bda-a2f1-2ea3b56b68f5@baylibre.com>
Date: Wed, 7 Feb 2024 10:55:07 +0100
From: Alexandre Mergnat <amergnat@...libre.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
chunkuang.hu@...nel.org
Cc: fshao@...omium.org, p.zabel@...gutronix.de, airlied@...il.com,
daniel@...ll.ch, matthias.bgg@...il.com, dri-devel@...ts.freedesktop.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH v4 1/9] drm/mediatek: dsi: Use GENMASK() for register mask
definitions
On 06/02/2024 16:53, AngeloGioacchino Del Regno wrote:
>>> #define DSI_PSCTRL 0x1c
>>> -#define DSI_PS_WC 0x3fff
>>> -#define DSI_PS_SEL (3 << 16)
>>> +#define DSI_PS_WC GENMASK(14, 0)
>>> +#define DSI_PS_SEL GENMASK(19, 16)
>>
>> 0011 0000 0000 0000 0000 => GENMASK(17, 16)
>
> Alexandre, the reason for that is in the commit description :-P
>
> "While at it, also fix the DSI_PS_SEL mask to include all bits instead
> of just a subset of them."
Oh sorry...
Reviewed-by: Alexandre Mergnat <amergnat@...libre.com>
--
Regards,
Alexandre
Powered by blists - more mailing lists