linux-kernel - Re: [PATCH] gpio: set device type for GPIO chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 7 Feb 2024 10:49:05 +0000
From: Greg KH <gregkh@...uxfoundation.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] gpio: set device type for GPIO chips

On Wed, Feb 07, 2024 at 11:45:39AM +0100, Linus Walleij wrote:
> On Thu, Feb 1, 2024 at 5:28 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> 
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > It's useful to have the device type information for those sub-devices
> > that are actually GPIO chips registered with GPIOLIB. While at it: use
> > the device type struct to setup the release callback which is the
> > preferred way to use the device API.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> (...=
> > +static struct device_type gpio_dev_type = {

Can you make this structure const please?

> > +       .name = "gpio_chip",
> > +       .release = gpiodev_release,
> > +};
> > +       gdev->dev.type = &gpio_dev_type;
> >         gdev->dev.bus = &gpio_bus_type;
> >         gdev->dev.parent = gc->parent;
> 
> Looks good to me (TM) but we should run this by Greg so he get the chance
> to chime in, I doubt he will see it on LKML.

Yes thanks, I wouldn't have caught it...

greg k-h