linux-kernel - Re: [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 07 Feb 2024 14:42:22 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Jean-Loïc Charroud <lagiraudiere+linux@...e.fr>
Cc: Takashi Iwai <tiwai@...e.de>,
	Stefan Binding <sbinding@...nsource.cirrus.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Richard Fitzgerald <rf@...nsource.cirrus.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	patches@...nsource.cirrus.com
Subject: Re: [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD

On Tue, 06 Feb 2024 18:05:53 +0100,
Jean-Loïc Charroud wrote:
> 
> Fix device ID for "ASUS UM3402" and "ASUS UM6702RA/RC".
> Add _DSD values for "ASUS UM3402" to cs35l41_config_table[].

So far, so good, but...

> Reorder alc269_fixup_tbl[] by device id and remove duplicate QUIRK
> entry for device {0x1043, 0x1f62, "ASUS UX7602ZM"}.

Don't mix up multiple things in a single patch.
The sort of the existing entries has little to do with your change.
Leave it to another patch instead (with Fixes tag for the
corresponding commit, too).


thanks,

Takashi