linux-kernel - Re: [PATCH v3] clk: keystone: sci-clk: Adding support for non contiguous clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 7 Feb 2024 19:15:38 +0530
From: Kamlesh Gurudasani <kamlesh@...com>
To: Nishanth Menon <nm@...com>, Udit Kumar <u-kumar1@...com>
CC: <kristo@...nel.org>, <ssantosh@...nel.org>, <chandru@...com>,
        <rishabh@...com>, <vigneshr@...com>, <mturquette@...libre.com>,
        <sboyd@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>
Subject: Re: [PATCH v3] clk: keystone: sci-clk: Adding support for non
 contiguous clocks

Nishanth Menon <nm@...com> writes:

>
> A bit too nice coding ;) => I had been confused momentarily by clk_id = args.args[1]
> change just above till I saw that you are pre-incrementing
> clk_id - Is there a harm in leaving the original clk_id increment logic
> alone (it was much simpler to read up)?
>
Personlly, I think this is simpler as this keeps everything related to
parents inside while loop and increment only at one place.

The other logic will have increment inside condition and also at 2 other
places.

Let's Udit take a call.

Kamlesh