linux-kernel - Re: [PATCH][next] cpufreq: amd-pstate: Fix min_perf assignment in amd_pstate_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 7 Feb 2024 15:07:47 +0100
From: Tor Vic <torvic9@...lbox.org>
To: "Yuan, Perry" <Perry.Yuan@....com>, "Huang, Ray" <Ray.Huang@....com>,
 "rafael@...nel.org" <rafael@...nel.org>,
 "Limonciello, Mario" <Mario.Limonciello@....com>,
 "Shenoy, Gautham Ranjal" <gautham.shenoy@....com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
 Oleksandr Natalenko <oleksandr@...alenko.name>
Subject: Re: [PATCH][next] cpufreq: amd-pstate: Fix min_perf assignment in
 amd_pstate_adjust_perf()



On 2/7/24 14:54, Yuan, Perry wrote:
> [AMD Official Use Only - General]
> 
>   Hi Tor,
> 
>> -----Original Message-----
>> From: Tor Vic <torvic9@...lbox.org>
>> Sent: Wednesday, February 7, 2024 9:09 PM
>> To: Huang, Ray <Ray.Huang@....com>; Yuan, Perry
>> <Perry.Yuan@....com>; rafael@...nel.org
>> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>; linux-
>> pm@...r.kernel.org; Oleksandr Natalenko <oleksandr@...alenko.name>
>> Subject: [PATCH][next] cpufreq: amd-pstate: Fix min_perf assignment in
>> amd_pstate_adjust_perf()
>>
>> In the function amd_pstate_adjust_perf(), the 'min_perf' variable is set to
>> 'highest_perf' instead of 'lowest_perf'.
>>
>> Fixes: 1d215f0319c2 ("cpufreq: amd-pstate: Add fast switch function for AMD
>> P-State")
>> Reported-by: Oleksandr Natalenko <oleksandr@...alenko.name>
>> Signed-off-by: Tor Vic <torvic9@...lbox.org>
>> ---
>> IIRC, this was first reported by Oleksandr, hence the 'Reported-by' tag.
>> ---
>>    drivers/cpufreq/amd-pstate.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
>> index 08e112444c27..aa5e57e27d2b 100644
>> --- a/drivers/cpufreq/amd-pstate.c
>> +++ b/drivers/cpufreq/amd-pstate.c
>> @@ -577,7 +577,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
>>        if (target_perf < capacity)
>>                des_perf = DIV_ROUND_UP(cap_perf * target_perf,
>> capacity);
>>
>> -     min_perf = READ_ONCE(cpudata->highest_perf);
>> +     min_perf = READ_ONCE(cpudata->lowest_perf);
>>        if (_min_perf < capacity)
>>                min_perf = DIV_ROUND_UP(cap_perf * _min_perf, capacity);
>>
>> --
>> 2.43.0
> 
> Thanks for the fix!

I think this is actually for stable and mainline too, not only for -next.
Should I resend with 'Cc: stable' tag and your Reviewed-by?

> 
> Reviewed-by: Perry Yuan <Perry.Yuan@....com>