linux-kernel - Re: [PATCH][next] mt76: Remove redundant assignment to variable tidno

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13e2f96c-2434-4266-8a5e-25b267d1fb0e@gmail.com>
Date: Wed, 7 Feb 2024 14:53:51 +0000
From: "Colin King (gmail)" <colin.i.king@...il.com>
To: Kalle Valo <kvalo@...nel.org>
Cc: Felix Fietkau <nbd@....name>, Lorenzo Bianconi <lorenzo@...nel.org>,
 Ryder Lee <ryder.lee@...iatek.com>, Shayne Chen <shayne.chen@...iatek.com>,
 Sean Wang <sean.wang@...iatek.com>, Matthias Brugger
 <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-wireless@...r.kernel.org, linux-mediatek@...ts.infradead.org,
 kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH][next] mt76: Remove redundant assignment to variable tidno

On 07/02/2024 13:31, Kalle Valo wrote:
> Colin Ian King <colin.i.king@...il.com> writes:
> 
>> The variable tidno is being assigned a value that is not being read
>> and is being re-assigned a new value a few statements later.
>> The assignment is redundant and can be removed.
>>
>> Cleans up clang scan warning:
>> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
>> to 'tidno' during its initialization is never read [deadcode.DeadStores]
>>
>> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> 
> "wifi:" missing from title.
> 
does this require a V2?