linux-kernel - Re: [PATCH v2] media: ti: Use devm_platform_ioremap_resource() in ti_csi2rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 7 Feb 2024 20:48:29 +0530
From: Jai Luthra <j-luthra@...com>
To: Markus Elfring <Markus.Elfring@....de>
CC: <linux-media@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        Mauro
 Carvalho Chehab <mchehab@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] media: ti: Use devm_platform_ioremap_resource() in
 ti_csi2rx_probe()

Hi Markus,

On Feb 06, 2024 at 15:37:30 +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 6 Feb 2024 15:30:13 +0100
> 
> A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42
> ("drivers: provide devm_platform_ioremap_resource()").
> 
> * Thus reuse existing functionality instead of keeping duplicate source code.
> 
> * Delete a local variable which became unnecessary with this refactoring.
> 
> 
> This issue was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Reviewed-by: Jai Luthra <j-luthra@...com>

> ---
> 
> v2:
> The transformation pattern was adjusted based on advices by known contributors.
> 
> Examples:
> * Doug Anderson
> * Geert Uytterhoeven
> * Robin Murphy
> 
> 
>  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> index 2b078c5d7f5d..54aba055c96b 100644
> --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> @@ -1089,7 +1089,6 @@ static void ti_csi2rx_cleanup_vb2q(struct ti_csi2rx_dev *csi)
>  static int ti_csi2rx_probe(struct platform_device *pdev)
>  {
>  	struct ti_csi2rx_dev *csi;
> -	struct resource *res;
>  	int ret;
> 
>  	csi = devm_kzalloc(&pdev->dev, sizeof(*csi), GFP_KERNEL);
> @@ -1100,9 +1099,7 @@ static int ti_csi2rx_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, csi);
> 
>  	mutex_init(&csi->mutex);
> -
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	csi->shim = devm_ioremap_resource(&pdev->dev, res);
> +	csi->shim = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(csi->shim)) {
>  		ret = PTR_ERR(csi->shim);
>  		goto err_mutex;
> --
> 2.43.0
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)