linux-kernel - Re: [PATCH] scsi: core: really include kunit tests with SCSI_LIB_KUNIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82889f67-adf3-4643-902e-2c8f581eb05a@oracle.com>
Date: Wed, 7 Feb 2024 09:37:02 -0600
From: michael.christie@...cle.com
To: Lukas Bulwahn <lukas.bulwahn@...il.com>, Christoph Hellwig <hch@....de>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        linux-scsi@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: core: really include kunit tests with
 SCSI_LIB_KUNIT_TEST

On 2/7/24 8:56 AM, Lukas Bulwahn wrote:
> Commit 25a1f7a0a1fe ("scsi: core: Add kunit tests for
> scsi_check_passthrough()") adds the config SCSI_LIB_KUNIT_TEST and
> corresponding tests. Due to naming confusion, the actual tests would only
> be included when the non-existing config SCSI_KUNIT_TEST is enabled (note
> this missing 'LIB' in the config name). So, they are basically dead right
> now.
> 
> Adjust the name to actual existing config.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>  drivers/scsi/scsi_lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 23719b903259..0315a0dc3406 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -3428,6 +3428,6 @@ void scsi_build_sense(struct scsi_cmnd *scmd, int desc, u8 key, u8 asc, u8 ascq)
>  }
>  EXPORT_SYMBOL_GPL(scsi_build_sense);
>  
> -#ifdef CONFIG_SCSI_KUNIT_TEST
> +#ifdef CONFIG_SCSI_LIB_KUNIT_TEST
>  #include "scsi_lib_test.c"
>  #endif

I tried to sneak a rename in last minute and messed that up. Thanks.

Reviewed-by: Mike Christie <michael.christie@...cle.com>