linux-kernel - Re: [PATCH 1/2] crypto: ccp: Avoid discarding errors in psp_send_platform_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 8 Feb 2024 10:24:32 -0700
From: Tim Van Patten <timvp@...gle.com>
To: Mario Limonciello <mario.limonciello@....com>
Cc: Herbert Xu <herbert@...dor.apana.org.au>, Tom Lendacky <thomas.lendacky@....com>, 
	John Allen <john.allen@....com>, 
	"open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..." <linux-crypto@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] crypto: ccp: Avoid discarding errors in psp_send_platform_access_msg()

On Wed, Feb 7, 2024 at 2:55 PM Mario Limonciello
<mario.limonciello@....com> wrote:
>
> When the PSP_CMDRESP_STS field has an error set, the details of the
> error are in `req->header->status`, and the caller will want to look
> at them. But if there is no error set then caller may want to check
> `req->header->status` separately.
>
> Stop discarding these errors.
>
> Reported-by: Tim Van Patten <timvp@...gle.com>
> Fixes: 7ccc4f4e2e50 ("crypto: ccp - Add support for an interface for platform features")
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
>  drivers/crypto/ccp/platform-access.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/platform-access.c b/drivers/crypto/ccp/platform-access.c
> index 94367bc49e35..792ae8d5b11a 100644
> --- a/drivers/crypto/ccp/platform-access.c
> +++ b/drivers/crypto/ccp/platform-access.c
> @@ -120,7 +120,8 @@ int psp_send_platform_access_msg(enum psp_platform_access_msg msg,
>
>         /* Store the status in request header for caller to investigate */
>         cmd_reg = ioread32(cmd);
> -       req->header.status = FIELD_GET(PSP_CMDRESP_STS, cmd_reg);
> +       if (FIELD_GET(PSP_CMDRESP_STS, cmd_reg))
> +               req->header.status = FIELD_GET(PSP_CMDRESP_STS, cmd_reg);
>         if (req->header.status) {
>                 ret = -EIO;
>                 goto unlock;
> --
> 2.34.1
>

Tested-by: Tim Van Patten <timvp@...gle.com>