linux-kernel - Re: [PATCH] workqueue: make wq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024020820-chaos-scale-33cf@gregkh>
Date: Thu, 8 Feb 2024 17:28:04 +0000
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Tejun Heo <tj@...nel.org>
Cc: "Ricardo B. Marliere" <ricardo@...liere.net>,
	Lai Jiangshan <jiangshanlai@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] workqueue: make wq_subsys const

On Thu, Feb 08, 2024 at 06:54:57AM -1000, Tejun Heo wrote:
> On Thu, Feb 08, 2024 at 10:10:56AM +0000, Greg Kroah-Hartman wrote:
> > On Wed, Feb 07, 2024 at 06:34:27AM -1000, Tejun Heo wrote:
> > > On Wed, Feb 07, 2024 at 10:12:34AM +0000, Greg Kroah-Hartman wrote:
> > > > On Tue, Feb 06, 2024 at 03:05:06PM -0300, Ricardo B. Marliere wrote:
> > > > > Now that the driver core can properly handle constant struct bus_type,
> > > > > move the wq_subsys variable to be a constant structure as well,
> > > > > placing it into read-only memory which can not be modified at runtime.
> > > > > 
> > > > > Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > > > Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>
> > > > > ---
> > > > > The maintainer asked [1] for this patch to be received through the
> > > > > driver-core tree.
> > > > > [1]: https://lore.kernel.org/all/ZcEeOueCbrltxr_b@slm.duckdns.org/
> > > > 
> > > > There is no cross-tree dependency at all, but hey, I'll take it, no
> > > > worries...
> > > 
> > > Ah, my bad. I branched out wq/for-6.9 before rc1 and was assuming the
> > > dependent commit was still in the driver core branch. I should have just
> > > pulled linus#master.
> > 
> > The dependent changes are in 6.4, so before -rc1 would have been ok as
> > well :)
> 
> Hmmm....
> 
>  > git log -1 --oneline 32f78abe59c7
>  32f78abe59c7 driver core: bus: constantify subsys_register() calls
>  > git describe --contains 32f78abe59c7
>  v6.8-rc1~61^2~10

Ugh, sorry, you are totally right.  Too many different "make X const"
series are floating around now, my fault.  I'll go suck this in now to
end the pointless discussion where I am proven wrong multiple times :)

greg k-h