linux-kernel - Re: [PATCH net-next v6 3/4] eventpoll: Add per-epoll prefer busy poll option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 8 Feb 2024 18:49:23 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Joe Damato <jdamato@...tly.com>, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org, chuck.lever@...cle.com, jlayton@...nel.org, 
	linux-api@...r.kernel.org, brauner@...nel.org, davem@...emloft.net, 
	alexander.duyck@...il.com, sridhar.samudrala@...el.com, 
	willemdebruijn.kernel@...il.com, weiwan@...gle.com, David.Laight@...lab.com, 
	arnd@...db.de, sdf@...gle.com, amritha.nambiar@...el.com, 
	Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, 
	"open list:FILESYSTEMS (VFS and infrastructure)" <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH net-next v6 3/4] eventpoll: Add per-epoll prefer busy poll option

On Wed, Feb 7, 2024 at 8:04 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon,  5 Feb 2024 21:04:48 +0000 Joe Damato wrote:
> > When using epoll-based busy poll, the prefer_busy_poll option is hardcoded
> > to false. Users may want to enable prefer_busy_poll to be used in
> > conjunction with gro_flush_timeout and defer_hard_irqs_count to keep device
> > IRQs masked.
> >
> > Other busy poll methods allow enabling or disabling prefer busy poll via
> > SO_PREFER_BUSY_POLL, but epoll-based busy polling uses a hardcoded value.
> >
> > Fix this edge case by adding support for a per-epoll context
> > prefer_busy_poll option. The default is false, as it was hardcoded before
> > this change.
>
> Reviewed-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>