linux-kernel - Re: [PATCH v1 14/15] dt-bindings: auxdisplay: Add Maxim MAX6958/6959

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 8 Feb 2024 17:50:51 +0000
From: Conor Dooley <conor@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Miguel Ojeda <ojeda@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Robin van der Gracht <robin@...tonic.nl>,
	Paul Burton <paulburton@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH v1 14/15] dt-bindings: auxdisplay: Add Maxim MAX6958/6959

On Thu, Feb 08, 2024 at 06:58:57PM +0200, Andy Shevchenko wrote:
> Add initial device tree documentation for Maxim MAX6958/6959.

Why "initial"? Are there elements this display that you've not
documented yet? 

> +title: MAX6958/6959 7-segment LED display controller with keyscan

> +properties:
> +  compatible:
> +    const: maxim,max6959

Where's the max6958's compatible? I don't see it in your driver either.
It seems that the max6959 has some interrupt capabilities that are not
available on the max6958, so a dedicated compatible seems suitable to
me.


Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)