linux-kernel - Re: [PATCH V2] virtio-blk: Ensure no requests in virtqueues before deleting vqs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170741716688.1391883.2946265788968193577.b4-ty@kernel.dk>
Date: Thu, 08 Feb 2024 11:32:46 -0700
From: Jens Axboe <axboe@...nel.dk>
To: stefanha@...hat.com, mst@...hat.com, jasowang@...hat.com, 
 Yi Sun <yi.sun@...soc.com>
Cc: sunyibuaa@...il.com, hongyu.jin@...soc.com, zhiguo.niu@...soc.com, 
 xuanzhuo@...ux.alibaba.com, pbonzini@...hat.com, 
 virtualization@...ts.linux.dev, linux-block@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] virtio-blk: Ensure no requests in virtqueues before
 deleting vqs.

On Mon, 29 Jan 2024 16:52:50 +0800, Yi Sun wrote:
> Ensure no remaining requests in virtqueues before resetting vdev and
> deleting virtqueues. Otherwise these requests will never be completed.
> It may cause the system to become unresponsive.
> 
> Function blk_mq_quiesce_queue() can ensure that requests have become
> in_flight status, but it cannot guarantee that requests have been
> processed by the device. Virtqueues should never be deleted before
> all requests become complete status.
> 
> [...]

Applied, thanks!

[1/1] virtio-blk: Ensure no requests in virtqueues before deleting vqs.
      (no commit info)

Best regards,
-- 
Jens Axboe