linux-kernel - Re: [PATCH 3/7] fs/writeback: remove unused parameter wb of finish_writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 08 Feb 2024 11:26:10 -0800
From: Tim Chen <tim.c.chen@...ux.intel.com>
To: Kemeng Shi <shikemeng@...weicloud.com>, viro@...iv.linux.org.uk, 
	brauner@...nel.org, jack@...e.cz
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] fs/writeback: remove unused parameter wb of
 finish_writeback_work

On Fri, 2024-02-09 at 01:20 +0800, Kemeng Shi wrote:
> Remove unused parameter wb of finish_writeback_work.
> 
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>

Reviewed-by: Tim Chen <tim.c.chen@...ux.intel.com>

> ---
>  fs/fs-writeback.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index edb0cff51673..2619f74ced70 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -166,8 +166,7 @@ static void wb_wakeup_delayed(struct bdi_writeback *wb)
>  	spin_unlock_irq(&wb->work_lock);
>  }
>  
> -static void finish_writeback_work(struct bdi_writeback *wb,
> -				  struct wb_writeback_work *work)
> +static void finish_writeback_work(struct wb_writeback_work *work)
>  {
>  	struct wb_completion *done = work->done;
>  
> @@ -196,7 +195,7 @@ static void wb_queue_work(struct bdi_writeback *wb,
>  		list_add_tail(&work->list, &wb->work_list);
>  		mod_delayed_work(bdi_wq, &wb->dwork, 0);
>  	} else
> -		finish_writeback_work(wb, work);
> +		finish_writeback_work(work);
>  
>  	spin_unlock_irq(&wb->work_lock);
>  }
> @@ -2285,7 +2284,7 @@ static long wb_do_writeback(struct bdi_writeback *wb)
>  	while ((work = get_next_work_item(wb)) != NULL) {
>  		trace_writeback_exec(wb, work);
>  		wrote += wb_writeback(wb, work);
> -		finish_writeback_work(wb, work);
> +		finish_writeback_work(work);
>  	}
>  
>  	/*