linux-kernel - Re: [PATCH 0/2] usb: dwc3: drop 'quirk' suffix at snps,host-vbus-glitches-quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240208-unquote-palace-83edc6220acd@spud>
Date: Thu, 8 Feb 2024 21:11:10 +0000
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Felipe Balbi <balbi@...nel.org>,
	Thinh Nguyen <Thinh.Nguyen@...opsys.com>, linux-usb@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev
Subject: Re: [PATCH 0/2] usb: dwc3: drop 'quirk' suffix at
 snps,host-vbus-glitches-quirk

On Wed, Feb 07, 2024 at 05:14:01PM -0500, Frank Li wrote:
> On Wed, Feb 07, 2024 at 10:05:23PM +0000, Conor Dooley wrote:
> > On Wed, Feb 07, 2024 at 05:00:17PM -0500, Frank Li wrote:
> > > Since dt maintainer give comments at old thread
> > > https://lore.kernel.org/linux-usb/20240119213130.3147517-1-Frank.Li@nxp.com/
> > > 
> > > The patch v4 already merged.
> > > https://lore.kernel.org/linux-usb/20240124152525.3910311-1-Frank.Li@nxp.com/
> > > 
> > > So submit new patch to rename snps,host-vbus-glitches-quirk to
> > > snps,host-vbus-glitches to align dt maintainer's comments.
> > 
> > I thought the last comment left on the v1 was Thinh agreeing that a
> > DT property was not needed here and we should be able to apply this
> > conditionally?
> 
> I don't think so. This is workaround. We can use this track which chip
> actually need this. If some year later, such chips already end of life.
> We have chance to clear up these code. Otherwise, it will keep there for
> ever.

> And I am not sure that the side effect for other chips. Workaround should
> be applied as less as possible.

I'd rather do it unconditionally if we can, but if you and Thinh think
that we cannot do it unconditionally then sure, keep the property.

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Cheers,
Conor.


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)