[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 8 Feb 2024 13:21:12 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Dan Williams <dan.j.williams@...el.com>, Arnd Bergmann <arnd@...db.de>,
Dave Chinner <david@...morbit.com>, linux-kernel@...r.kernel.org, Linus
Torvalds <torvalds@...ux-foundation.org>, Vishal Verma
<vishal.l.verma@...el.com>, Dave Jiang <dave.jiang@...el.com>, Matthew
Wilcox <willy@...radead.org>, Russell King <linux@...linux.org.uk>,
linux-arch@...r.kernel.org, linux-cxl@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
linux-xfs@...r.kernel.org, dm-devel@...ts.linux.dev,
nvdimm@...ts.linux.dev, linux-s390@...r.kernel.org, Alasdair Kergon
<agk@...hat.com>, Mike Snitzer <snitzer@...nel.org>, Mikulas Patocka
<mpatocka@...hat.com>
Subject: Re: [PATCH v4 01/12] nvdimm/pmem: Fix leak on dax_add_host()
failure
On Thu, 8 Feb 2024 13:49:02 -0500 Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:
> Fix a leak on dax_add_host() error, where "goto out_cleanup_dax" is done
> before setting pmem->dax_dev, which therefore issues the two following
> calls on NULL pointers:
>
> out_cleanup_dax:
> kill_dax(pmem->dax_dev);
> put_dax(pmem->dax_dev);
Seems inappropriate that this fix is within this patch series?
otoh I assume dax_add_host() has never failed so it doesn't matter much.
The series seems useful but is at v4 without much sign of review
activity. I think I'll take silence as assent and shall slam it all
into -next and see who shouts at me.
Powered by blists - more mailing lists