linux-kernel - Re: [PATCH] dt-bindings: input: atmel,captouch: convert bindings to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 8 Feb 2024 03:59:55 +0000
From: <Dharma.B@...rochip.com>
To: <krzysztof.kozlowski@...aro.org>, <dmitry.torokhov@...il.com>,
	<robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
	<conor+dt@...nel.org>, <Nicolas.Ferre@...rochip.com>,
	<alexandre.belloni@...tlin.com>, <claudiu.beznea@...on.dev>,
	<linux-input@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: input: atmel,captouch: convert bindings to
 YAML

Hi Krzysztof,

On 07/02/24 8:45 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 07/02/2024 10:08, Dharma Balasubiramani wrote:
>> Convert the Atmel capacitive touchscreen bindings to YAML format.
>>
>> Signed-off-by: Dharma Balasubiramani <dharma.b@...rochip.co
> 
> Thank you for your patch. There is something to discuss/improve.
> 
>> +
>> +properties:
>> +  compatible:
>> +    const: atmel,captouch
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  linux,keycodes:
>> +    minItems: 1
>> +    maxItems: 8
>> +
>> +  autorepeat:
>> +    type: boolean
> 
> You can drop entire property, coming from input.yaml.

Sure, I will drop the 'linux,keycodes' and 'autorepeat' properties.
> 
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - linux,keycodes
>> +
>> +additionalProperties: false
> 
> Instead:
> unevaluatedProperties: false

Noted, Thanks.
> 
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +    #include <dt-bindings/input/linux-event-codes.h>
>> +    i2c {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +      atmel-captouch@51 {
> 
> Instead:
> touchscreen? touchpad? if none of these, then just "touch@51"

I will go with touch@51.

Thanks.
> 
>> +        compatible = "atmel,captouch";
>> +        reg = <0x51>;
> 
> 
> Best regards,
> Krzysztof
> 

-- 
With Best Regards,
Dharma B.