linux-kernel - Re: [PATCH v1 0/3] iwlwifi: mvm: Thermal management fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xyzh4ah.fsf@kernel.org>
Date: Thu, 08 Feb 2024 08:13:26 +0200
From: Kalle Valo <kvalo@...nel.org>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc: Linux PM <linux-pm@...r.kernel.org>,  Gregory Greenman
 <gregory.greenman@...el.com>,  Miri Korenblit
 <miriam.rachel.korenblit@...el.com>,  Johannes Berg
 <johannes.berg@...el.com>,  linux-wireless@...r.kernel.org,  LKML
 <linux-kernel@...r.kernel.org>,  Daniel Lezcano
 <daniel.lezcano@...aro.org>,  Stanislaw Gruszka
 <stanislaw.gruszka@...ux.intel.com>
Subject: Re: [PATCH v1 0/3] iwlwifi: mvm: Thermal management fixes

"Rafael J. Wysocki" <rjw@...ysocki.net> writes:

> There are a few thermal management shortcomings in the iwlwifi driver that are
> addressed by this series.
>
> First off, the fw_trips_index[] array field in struct iwl_mvm_thermal_device
> is only populated and never read, and the code populating it has problems,
> so patch [1/3] removes it.
>
> Second, iwl_mvm_thermal_zone_register() populates the trip table after passing
> it to thermal_zone_device_register_with_trips() which is too late, because it
> can get used before it is populated.  It also may as well use THERMAL_TEMP_INVALID
> as the "invalid temperature" value.  Both these issues are addressed by patch [2/3].
>
> Finally, iwl_mvm_send_temp_report_ths_cmd() accesses the trip tables used during
> thermal zone registration directly in order to obtain the current trip point
> temperature values, which is not guaranteed to work in the future, because the
> core will store the trips information in its own copy of the trip table - see
> this patch series:
>
> https://lore.kernel.org/linux-pm/2728491.mvXUDI8C0e@kreacher/
>
> If possible, I'd like to route the $subject series through the thermal tree,
> it is requisite for the above one.

iwlwifi is getting a lot of patches lately, though I don't know if any
of them touch the thermal stuff. But if this patchset goes to the
thermal I am a bit worried about conflicts.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches