[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<SA1PR12MB7199AA9F83CE8E7F1E8B0022B0442@SA1PR12MB7199.namprd12.prod.outlook.com>
Date: Thu, 8 Feb 2024 06:43:02 +0000
From: Ankit Agrawal <ankita@...dia.com>
To: "Tian, Kevin" <kevin.tian@...el.com>, Jason Gunthorpe <jgg@...dia.com>,
"alex.williamson@...hat.com" <alex.williamson@...hat.com>, Yishai Hadas
<yishaih@...dia.com>, "mst@...hat.com" <mst@...hat.com>,
"shameerali.kolothum.thodi@...wei.com"
<shameerali.kolothum.thodi@...wei.com>, "clg@...hat.com" <clg@...hat.com>,
"oleksandr@...alenko.name" <oleksandr@...alenko.name>, "K V P, Satyanarayana"
<satyanarayana.k.v.p@...el.com>, "eric.auger@...hat.com"
<eric.auger@...hat.com>, "brett.creeley@....com" <brett.creeley@....com>,
"horms@...nel.org" <horms@...nel.org>, Rahul Rameshbabu
<rrameshbabu@...dia.com>
CC: Aniket Agashe <aniketa@...dia.com>, Neo Jia <cjia@...dia.com>, Kirti
Wankhede <kwankhede@...dia.com>, "Tarun Gupta (SW-GPU)"
<targupta@...dia.com>, Vikram Sethi <vsethi@...dia.com>, Andy Currid
<acurrid@...dia.com>, Alistair Popple <apopple@...dia.com>, John Hubbard
<jhubbard@...dia.com>, Dan Williams <danw@...dia.com>, "Anuj Aggarwal
(SW-GPU)" <anuaggarwal@...dia.com>, Matt Ochs <mochs@...dia.com>,
"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "virtualization@...ts.linux-foundation.org"
<virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH v17 2/3] vfio/pci: rename and export range_intesect_range
Thanks Kevin.
>> range_intesect_range determines an overlap between two ranges. If an
>
> s/intesect/intersect/
Will fix the typo.
>> + * vfio_pci_core_range_intersect_range() - Determine overlap between a
>> buffer
>> + * and register offset ranges.
>> + * @range1_start: start offset of the buffer
>> + * @count1: number of buffer bytes.
>> + * @range2_start: start register offset
>> + * @count2: number of bytes of register
>> + * @start_offset: start offset of overlap start in the buffer
>> + * @intersect_count: number of overlapping bytes
>> + * @register_offset: start offset of overlap start in register
>> + *
>> + * The function determines an overlap between a register and a buffer.
>> + * range1 represents the buffer and range2 represents register.
>> + *
>> + * Returns: true if there is overlap, false if not.
>> + * The overlap start and range is returned through function args.
>> + */
>> +bool vfio_pci_core_range_intersect_range(loff_t range1_start, size_t count1,
>> + loff_t range2_start, size_t count2,
>> + loff_t *start_offset,
>> + size_t *intersect_count,
>> + size_t *register_offset)
>
> based on description it's probably clearer to rename:
>
> range1_start -> buf_start
> count1 -> buf_cnt
> range2_start -> reg_start
> count2 -> reg_cnt
> start_offset -> buf_offset
>
> but not big deal, so:
Fine by me. Will rename them.
> Reviewed-by: Kevin Tian <kevin.tian@...el.com>
Thanks!
Powered by blists - more mailing lists