[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a4949983-f6ba-4d98-b180-755de6b11d0f@linaro.org>
Date: Thu, 8 Feb 2024 08:35:54 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>,
davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, afd@...com,
andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, bsp-development.geo@...ca-geosystems.com,
m.felsch@...gutronix.de
Subject: Re: [PATCH v2 1/2] dt-bindings: net: dp83826: support TX data voltage
tuning
On 07/02/2024 18:58, Catalin Popescu wrote:
> Add properties ti,cfg-dac-minus-one-milli-percent and
> ti,cfg-dac-plus-one-milli-percent to support voltage tuning
> of logical levels -1/+1 of the MLT-3 encoded TX data.
>
> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
> ---
> Changes in v2:
> - squash the 2 DT bindings patches in one single patch
> - drop redundant "binding" from the DT bindings patch title
> - rename DT properties and define them as percentage
> - add default value for each new DT property
> ---
> .../devicetree/bindings/net/ti,dp83822.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> index db74474207ed..6bbd465e51d6 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> @@ -62,6 +62,24 @@ properties:
> for the PHY. The internal delay for the PHY is fixed to 3.5ns relative
> to transmit data.
>
> + ti,cfg-dac-minus-one-milli-percent:
> + description: |
> + DP83826 PHY only.
> + Sets the voltage ratio (with respect to the nominal value)
> + of the logical level -1 for the MLT-3 encoded TX data.
> + enum: [50000, 56250, 62500, 68750, 75000, 81250, 87500, 93750, 100000,
> + 106250, 112500, 118750, 125000, 131250, 137500, 143750, 150000]
I see all values being multiple of basis points, so why not using -bp
suffix?
Best regards,
Krzysztof
Powered by blists - more mailing lists