linux-kernel - Re: [PATCH rc 8/8] iommu/vt-d: Add missing dirty tracking set for parent domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <defdccc8-449d-42a7-aee6-8ac212a777ba@intel.com>
Date: Thu, 8 Feb 2024 17:23:59 +0800
From: Yi Liu <yi.l.liu@...el.com>
To: "Tian, Kevin" <kevin.tian@...el.com>, "joro@...tes.org" <joro@...tes.org>,
	"jgg@...dia.com" <jgg@...dia.com>, "baolu.lu@...ux.intel.com"
	<baolu.lu@...ux.intel.com>
CC: "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
	"robin.murphy@....com" <robin.murphy@....com>, "eric.auger@...hat.com"
	<eric.auger@...hat.com>, "nicolinc@...dia.com" <nicolinc@...dia.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "chao.p.peng@...ux.intel.com"
	<chao.p.peng@...ux.intel.com>, "yi.y.sun@...ux.intel.com"
	<yi.y.sun@...ux.intel.com>, "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@...el.com>, "joao.m.martins@...cle.com"
	<joao.m.martins@...cle.com>
Subject: Re: [PATCH rc 8/8] iommu/vt-d: Add missing dirty tracking set for
 parent domain

On 2024/2/8 16:53, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@...el.com>
>> Sent: Thursday, February 8, 2024 4:23 PM
>>
>> @@ -4760,6 +4790,12 @@ static int intel_iommu_set_dirty_tracking(struct
>> iommu_domain *domain,
>>   	if (ret)
>>   		goto err_unwind;
>>
>> +	if (dmar_domain->nested_parent) {
>> +		ret = parent_domain_set_dirty_tracking(dmar_domain,
>> enable);
>> +		if (ret)
>> +			goto err_unwind;
>> +	}
>> +
> 
> there also lack of setting dirty tracking when a device is attached to the
> nested domain while the parent already has dirty-tracking enabled.
> 
> but looks even w/o nesting this is missed in the attach path.
> 
> could be fixed separately. so for this one:

it's fixed here. 
https://lore.kernel.org/linux-iommu/20240208091414.28133-1-yi.l.liu@intel.com/

> Reviewed-by: Kevin Tian <kevin.tian@...el.com>

-- 
Regards,
Yi Liu